Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move IntermediateCertTTL to common CA config #8646

Merged
merged 2 commits into from
Sep 15, 2020
Merged

Conversation

kyhavlov
Copy link
Contributor

This PR moves the IntermediateCertTTL field into the common CA config so that it can be used in the Vault provider. The documentation sort of implied this was already the case, but it was actually a field specific to the Consul CA.

@dnephin dnephin added the theme/certificates Related to creating, distributing, and rotating certificates in Consul label Sep 10, 2020
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I guess this warrants a .changelog/ file, and some backport labels?

@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 35bb09f onto release/1.8.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Sep 15, 2020
Move IntermediateCertTTL to common CA config
@kyhavlov kyhavlov mentioned this pull request Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/certificates Related to creating, distributing, and rotating certificates in Consul
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants